terraform-aws-modules / terraform-aws-acm

Terraform module to create AWS ACM resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/acm/aws
Apache License 2.0
182 stars 229 forks source link

chore: Add third example for multi-provider #147

Closed hobbsh closed 5 months ago

hobbsh commented 6 months ago

Description

This PR adds another example for multi-provider configuration when calling this module with for_each. I commented the example because pre-commit broke due to this needing to be implemented slightly differently than the others.

Motivation and Context

In response to https://github.com/terraform-aws-modules/terraform-aws-acm/issues/146

Breaking Changes

None

How Has This Been Tested?

hobbsh commented 6 months ago

@antonbabenko This method does not work without modifications to the module to support multiple provider configurations. Your comment in #146 led me to believe you don't want to support multiple provider configurations so I thought this was going to just be a way to document the workaround. If that's not the way forward, that's ok.

github-actions[bot] commented 5 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 5 months ago

This PR was automatically closed because of stale in 10 days

github-actions[bot] commented 4 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.