terraform-aws-modules / terraform-aws-acm

Terraform module to create AWS ACM resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/acm/aws
Apache License 2.0
184 stars 230 forks source link

feat: Bump aws provider to 5.0 #148

Closed lays147 closed 8 months ago

lays147 commented 8 months ago

Description

I need some terraform features that are only available in terraform 5.0, and I'm unable to use it because of this module provider version. So I'm opening this PR to bump it to 5.0

Motivation and Context

Conflicts between the provider configuration of the module and of my project

Breaking Changes

It appears that does not break anything, since I used my fork's version in my project and no changes to the ACM config were found.

How Has This Been Tested?

antonbabenko commented 8 months ago

This module requires AWS provider 4.40+, so you should be able to use any newer version of AWS provider without the need to bump the version of the provider here.

We will bump the version of the provider in the module as soon as we implement features that are available only in the newer version of AWS provider. We already require minimum version of Terraform AWS provider in the module.

github-actions[bot] commented 7 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.