feat: Allow multiple domains in a single certificate

alemarmed commented 6 months ago

This is a follow up of https://github.com/terraform-aws-modules/terraform-aws-acm/pull/137 Credits to @amontalban for the work, I made requested changes and tested the feature.

Description

This PR allows creating one ACM certificate for multiple domains, which, is useful when using the certificate for CloudFront that only allows one certificate per distribution.

Motivation and Context

CloudFront does not support multiple ACM certificates, like ALB. Therefore, if you need to support multiple domains in a single CloudFront distribution you would have to create the certificate manually because this module does not support it.

Breaking Changes

This change should be backward compatible as I added a zones var containing a map with domains and their Route53 zone ID so the validation records are created in the correct Route53 zone.

Additionally, I have updated the tests in examples/complete-dns-validation to allow variables so it was easier for me (and others) to test with my test domains.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

Fixes https://github.com/terraform-aws-modules/terraform-aws-acm/issues/136

alemarmed commented 5 months ago

Hi @antonbabenko, is there a chance of resuming the review that you left on https://github.com/terraform-aws-modules/terraform-aws-acm/pull/137 here? Thanks.

amontalban commented 5 months ago

Thank you @alemarmed for doing this, I totally dropped the ball on the #137 but glad you created this because now I'm needing this again 🤣.

riptidewave93 commented 5 months ago

Would also love to see this feature merged! :)

amontalban commented 4 months ago

@bryantbiggs any chance you can check this out? Thanks!

github-actions[bot] commented 3 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

nicolajv commented 3 months ago

This would be amazing to have, commenting to keep it alive

github-actions[bot] commented 2 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

y3ti commented 2 months ago

It would be great to have this feature!

Samseppiol commented 2 months ago

Waiting for this. It has been open since March, can a maintainer please review?

amontalban commented 2 months ago

@bryantbiggs @antonbabenko any chance you can review/merge this 🙏? Thanks!

github-actions[bot] commented 1 month ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

riptidewave93 commented 1 month ago

Another bump to prevent this PR from being stale. Really wish the maintainer would provide feedback here :(

antonbabenko commented 1 month ago

This PR is included in version 5.1.0 :tada:

github-actions[bot] commented 11 hours ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-acm