search

terraform-aws-modules / terraform-aws-acm

Terraform module to create AWS ACM resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/acm/aws
Apache License 2.0
184 stars 230 forks source link

feat: add dns ttl as variable #54

Closed tomasbackman closed 4 years ago

tomasbackman commented 4 years ago

Description

This is a PR with same changes as in: https://github.com/terraform-aws-modules/terraform-aws-acm/pull/35 Originally done by @rafaelkonrath

Motivation and Context

There is a small PR about this already but suggested changes and rebase/merge for it has not been done yet so I redid same, since I have some interest in this =) hopefully not stepping on anyones toes here.

Breaking Changes

No

How Has This Been Tested?

Same changes as has been reviewed by @bryantbiggs and more or less accepted then =)

bryantbiggs commented 4 years ago

thank you @tomasbackman - would you mind running the precmomit hook to update the documentation please?

tomasbackman commented 4 years ago

@bryantbiggs I guess I can try, but what hook is that? And how do I run it? I don't see any mention of any hook in neither the contributing guidelines nor the readme so Im not really sure on how..

It sounds like it is about updating the documentations? I guess I could do that manually as well, but yes a tool for it would be nice =)

bryantbiggs commented 4 years ago

thanks @tomasbackman - we'll have to take a look at updating the docs for that. you should have seen something show up on your cli when running git commit. here is a link to the project we typically use on these modules https://github.com/antonbabenko/pre-commit-terraform - at minimum you just need

once those are available on your machine its just a matter of running manually with pre-commit run -a or if you make changes to the codebase and run git commit the hook will kick in to fire also

bryantbiggs commented 4 years ago

@antonbabenko :+1:

antonbabenko commented 4 years ago

Great!

v2.9.0 has been released.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.