New usefull outputs to use with route53

terraform-aws-modules / terraform-aws-apigateway-v2

Terraform module to create AWS API Gateway v2 (HTTP/WebSocket) 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/apigateway-v2/aws

Apache License 2.0

144 stars 188 forks source link

New usefull outputs to use with route53 #11

Closed fedemzcor closed 3 years ago

fedemzcor commented 3 years ago

Description

the outputs this_apigatewayv2_target_domain_name and this_apigatewayv2_hosted_zone_id was added

Motivation and Context

to use a custom domain name with route 53

Breaking Changes

all ok!!!, 💯

How Has This Been Tested?

manual hard test with my own infraestructure

antonbabenko commented 3 years ago

Thanks for this addition. I have updated the code a bit to support the case when create_domain_name = false and updated names for outputs.

v0.8.0 has been just released.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.