search

terraform-aws-modules / terraform-aws-apigateway-v2

Terraform module to create AWS API Gateway v2 (HTTP/WebSocket) 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/apigateway-v2/aws
Apache License 2.0
151 stars 203 forks source link

fix: Add a way to prevent cloudwatch log group from being created #122

Open cedric-spinergie opened 1 month ago

cedric-spinergie commented 1 month ago

Fixes #115 #121

Description

Do not create cloudwatch log group if stage_access_log_settings == null.

Motivation and Context

See #115 & #121
Before this PR, it wasn't possible to prevent cloudwatch log group creation.

Breaking Changes

This is not a breaking change.

How Has This Been Tested?

Before this PR, setting stage_access_log_settings = null would result in a failing config so it's not possible to test before the change.
With the change, I was able to deploy my own config properly. (And omit the cloudwatch log group creation)

github-actions[bot] commented 3 weeks ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

cedric-spinergie commented 3 weeks ago

Not stale.