search

terraform-aws-modules / terraform-aws-apigateway-v2

Terraform module to create AWS API Gateway v2 (HTTP/WebSocket) 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/apigateway-v2/aws
Apache License 2.0
144 stars 188 forks source link

feat: Added support for mTLS and the ability to disable default endpoint #18

Closed anavarreteuk closed 3 years ago

anavarreteuk commented 3 years ago

Description

I have added the option to have mutual TLS in the api gateway domain and also the possibility to disable the default endpoint as does not require mutual TLS.

https://aws.amazon.com/blogs/compute/introducing-mutual-tls-authentication-for-amazon-api-gateway/

Motivation and Context

It gives the developer the option to enable mTLS and disable the non mTLS default endpoint Closes https://github.com/terraform-aws-modules/terraform-aws-apigateway-v2/issues/12

Breaking Changes

It does not introduce any breaking change

How Has This Been Tested?

Tested in my personal environment

antonbabenko commented 3 years ago

Thanks for the PR. In order to proceed with this, could you please make a new example by copying an existing one and show usage of mTLS feature?

davidkarlsen commented 3 years ago

@anavarreteuk seems like all that's left is to add an example? Is this something you intend to do? I think this addition (mtls) would be very valuable.

antonbabenko commented 3 years ago

Fixed by #29 and v0.15.0 has been just released.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.