search

terraform-aws-modules / terraform-aws-apigateway-v2

Terraform module to create AWS API Gateway v2 (HTTP/WebSocket) 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/apigateway-v2/aws
Apache License 2.0
144 stars 188 forks source link

Authorizer implementation #20

Closed alexjurkiewicz closed 2 years ago

alexjurkiewicz commented 3 years ago

Hi Anton, I like this module a lot! Do you have plans to add authorizer support to it? It's something I'm possibly interested in working on. Do you have ideas about how the implementation should look?

antonbabenko commented 3 years ago

Hi Alex! Recently there was #17 about authorization on routes.

If you are thinking about the creation of aws_apigatewayv2_authorizer resources by this module, then I don't have immediate plans to add those because I don't have a need for them myself.

From the implementation point of view, aws_apigatewayv2_authorizer resources should be similar to the relation between var.integrations and aws_apigatewayv2_route resources.

I will be glad to review the implementation if anyone wants to work on it.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 2 years ago

This issue was automatically closed because of stale in 10 days

bobbydeveaux commented 2 years ago

I've created a PR here: https://github.com/terraform-aws-modules/terraform-aws-apigateway-v2/pull/64

@antonbabenko do you mind giving a review please? :)

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.