search

terraform-aws-modules / terraform-aws-apigateway-v2

Terraform module to create AWS API Gateway v2 (HTTP/WebSocket) 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/apigateway-v2/aws
Apache License 2.0
150 stars 203 forks source link

fix: Remove workaround related to passthrough_behavior for older providers #24

Closed jamesla closed 3 years ago

jamesla commented 3 years ago

Description

Removing old workaround that is no longer needed.

Motivation and Context

The issue that this workaround resolves has been fixed in aws 3.3.0 and newer versions of terraform don't allow you to set lifecycle ignores for a property that isn't specified as far as I can tell.

The error is:

Error: expected passthrough_behavior to be one of [WHEN_NO_MATCH NEVER WHEN_NO_TEMPLATES], got

The issue is: https://github.com/terraform-providers/terraform-provider-aws/issues/11148#issuecomment-619160589

Breaking Changes

This update forces users to upgrade their version of the AWS provider from 2.59 to at least 3.3.0.

How Has This Been Tested?

I have tested this locally.

antonbabenko commented 3 years ago

Thanks for the improvement. This is completely acceptable to ask users to upgrade AWS provider.

AWS provider 3.3.0 has been released more than half a year ago.

v0.11.0 has been just released.

github-actions[bot] commented 2 years ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.