be able to control detailed_metrics_enabled, throttling_burst_limit, throttling_rate_limit

davidkarlsen commented 3 years ago

Is your request related to a new offering from AWS?

no

Is your request related to a problem? Please describe.

missing exposed functionality

Describe the solution you'd like.

be able to control: detailed_metrics_enabled, throttling_burst_limit, throttling_rate_limit

Describe alternatives you've considered.

coming from flat resources, want to replace them with this module.

Additional context

   ~ default_route_settings {
          ~ detailed_metrics_enabled = true -> false
          - throttling_burst_limit   = 100 -> null
          - throttling_rate_limit    = 100 -> null
            # (1 unchanged attribute hidden)
        }
        # (1 unchanged block hidden)

I actually see code for this https://github.com/terraform-aws-modules/terraform-aws-apigateway-v2/blob/5a7f67401c96bf6856fae8867da4492d9ac5af84/main.tf#L67 - but for some reason it's commented out?

it's problematic to not be able to set the limits as they will then be null, and all traffic will get throttled/denied.

antonbabenko commented 3 years ago

The main reason why not all features were implemented is that I didn't have a use case for them myself but also there were bugs in Terraform AWS provider.

PR which adds all the remaining arguments into this module is welcome.

Thanks!

davidkarlsen commented 3 years ago

Is it ok to upgrade the provider in the same PR?

antonbabenko commented 3 years ago

Yes, we can safely use the latest available version and add all currently present features into this module.

Once we have most of them implemented, I will make a new major release of this module and many of the open issues should be closed.

This is the plan. :)

davidkarlsen commented 3 years ago

Got it to work w/o touching provider.

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-apigateway-v2