search

terraform-aws-modules / terraform-aws-apigateway-v2

Terraform module to create AWS API Gateway v2 (HTTP/WebSocket) 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/apigateway-v2/aws
Apache License 2.0
150 stars 203 forks source link

Allow using existing domain name to create API mapping #36

Closed akuzni2 closed 2 years ago

akuzni2 commented 3 years ago

Is your request related to a new offering from AWS?

No - this is available if writing the resources from scratch

Is your request related to a problem? Please describe.

Must create new domain name to be able to create API mapping

Describe the solution you'd like.

This current module doesn't seem to work if you have an existing domain that you'd like to specify additional endpoints on top of it. Example my-existing-domain.com and I'd like to create api_v2 resource which adds a /new-endpoint on top of that domain. I should be able to specify an existing domain name and specify to create a new API mapping on top of that domain name

Describe alternatives you've considered.

N/A

Additional context

This line in this module does not currently allow that. It looks like everything must be TRUE (i.e.var.create_api_domain_name must be true) to be able to create the API mapping.

antonbabenko commented 3 years ago

Thanks for opening this issue! Very good point. This is indeed a missing feature, so PR is welcome.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 2 years ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 2 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.