Support for PrivateLink to NLB for Fargate

terraform-aws-modules / terraform-aws-apigateway-v2

Terraform module to create AWS API Gateway v2 (HTTP/WebSocket) 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/apigateway-v2/aws

Apache License 2.0

144 stars 188 forks source link

Support for PrivateLink to NLB for Fargate #4

Closed leeming closed 3 years ago

leeming commented 3 years ago

I'm currently learning API gateway and fargate and was just trying to figure out how to get this module to work with it.

It looks like connection_id is required for aws_apigatewayv2_integration, which is currently missing in the module definition. Is this right? Is this something you had foreseen, or am I working on an edge case here?

Usually I would take this as an opportunity to submit a PR, but I am still a little early with my understanding of the terraform required.

Thanks, and keep up the great work!

antonbabenko commented 3 years ago

Yes, this is right. Currently, there is only functionality which we use at Betajob and we will add new features as we have customers asking for this.

antonbabenko commented 3 years ago

Hi @leeming !

v0.13.0 has been just released, and connection_id is supported.

Also, please take a look at vpc-link-http example where I show integration of API Gateway with ALB.

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.