search

terraform-aws-modules / terraform-aws-apigateway-v2

Terraform module to create AWS API Gateway v2 (HTTP/WebSocket) 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/apigateway-v2/aws
Apache License 2.0
150 stars 203 forks source link

Adds dynamic block to include tls_config if it is present in the integrations input variable #50

Closed sharath-sequoia closed 3 years ago

sharath-sequoia commented 3 years ago

Description

Custom domain for integration requires us to provide tls_config for the integration. It was not possible to include this in this module, and this change would allow us to include this configuration within the integrations variable.

Motivation and Context

Earlier, there was no option to include this configuration for the API gateway integrations using this module. I have now added a dynamic block to include this configuration if it is present in the integrations input variable. Fixes #47.

Breaking Changes

There are no breaking changes.

How Has This Been Tested?

I have tested and validated these changes by including the tls_config map in the integrations input variable and confirmed it to be working as expected in our infrastructure.

antonbabenko commented 3 years ago

Please update the code in examples/complete-http for one of the existing integrations and make sure that this module does the job as expected.

github-actions[bot] commented 2 years ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.