feat!: Updates to support websocket API Gateway

bryantbiggs commented 3 years ago

Description

Additional changes

Minimum supported Terraform AWS provider raised to v5.37.0 to support recent bug fixes in the provider
Default values for api_key_selection_expression, route_selection_expression variables set to null (still matches prior value v4.x version but is set as null now)
The input data structure for routes (was integrations) has been updated and now uses optional inputs

Added

Support for creating a websocket API endpoint
Support for creating Route53 alias records for custom domain names w/ support for multiple sub-domains using a wildcard API Gateway custom domain name
Support for creating ACM certificate for custom domain
Support for automatically deploying the stage when updates have been made (for Websocket, HTTP is always auto-deployed by the API)

Modified

Stage access log group settings are now embedded into the stage_access_log_settings variable
API mapping is created automatically when using a custom domain
Default values of 500 and 1000 have been set for throttling_burst_limit and throttling_rate_limit respectively to ensure users do not face errors when deploying APIs for the first time and not configuring these
Default values for the log group name ("/aws/apigateway/${var.name}/${var.stage_name}") and retention period (30) have been provided for the stage access logs log group

Removed

None

See UPGRADE-5.0.md for full list of changes and notes on upgrade path

Motivation and Context

updates for websocket support

Closes #7 Closes #8 Closes #42 Closes #46 Closes #61

Breaking Changes

Yes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

lllama commented 3 years ago

Not sure if this affects #46 at all. That PR had a working example of a websockets API. I can update if needed.

antonbabenko commented 3 years ago

@lllama Thanks for the WebSocket example in #46!

I think it will be great if @bryantbiggs merges your example into this PR and update it to follow the rest of the examples we have.

github-actions[bot] commented 2 years ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

bryantbiggs commented 2 years ago

Shhhh

zkRemda commented 2 years ago

I'm interested on this, any updates?

schlbra commented 2 years ago

Is this feature just awaiting a review? This would be a great addition as we can't use this module as is.

bryantbiggs commented 2 years ago

Is this feature just awaiting a review? This would be a great addition as we can't use this module as is.

its waiting on me to finish it up, running a bit behind - my apologies. once I get https://github.com/terraform-aws-modules/terraform-aws-redshift/pull/61 across the line I'll focus on finish this one up as well

krishna-koushik commented 1 year ago

any update on this?

antonbabenko commented 1 year ago

@bryantbiggs Do you want me to work on this one? I am interested in improving https://serverless.tf , so this is a good addition.

bryantbiggs commented 1 year ago

@antonbabenko yes, please feel free to take this one over if you have the time

antonbabenko commented 1 year ago

Ok, I will work on it on Monday-Wednesday then.

ghost commented 1 year ago

Hi, are there any updates regarding this one? I'm really interested in this

choudharyac09 commented 5 months ago

Can We merge this pull request?

bryantbiggs commented 5 months ago

Can We merge this pull request?

Its being worked on, its currently in draft mode

choudharyac09 commented 5 months ago

@antonbabenko Can you please review the pull request?

antonbabenko commented 5 months ago

@antonbabenko Can you please review the pull request?

Yes, as soon as I can. Probably, tomorrow.

antonbabenko commented 5 months ago

This PR is included in version 5.0.0 :tada:

github-actions[bot] commented 4 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-apigateway-v2