terraform-aws-modules / terraform-aws-apigateway-v2

Terraform module to create AWS API Gateway v2 (HTTP/WebSocket) 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/apigateway-v2/aws
Apache License 2.0
144 stars 188 forks source link

feat!: Updates to support websocket API Gateway #54

Closed bryantbiggs closed 3 weeks ago

bryantbiggs commented 2 years ago

Description

Additional changes

Added

Modified

Removed

See UPGRADE-5.0.md for full list of changes and notes on upgrade path

Motivation and Context

Closes #7 Closes #8 Closes #42 Closes #46 Closes #61

Breaking Changes

How Has This Been Tested?

lllama commented 2 years ago

Not sure if this affects #46 at all. That PR had a working example of a websockets API. I can update if needed.

antonbabenko commented 2 years ago

@lllama Thanks for the WebSocket example in #46!

I think it will be great if @bryantbiggs merges your example into this PR and update it to follow the rest of the examples we have.

github-actions[bot] commented 2 years ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

bryantbiggs commented 2 years ago

Shhhh

zkRemda commented 2 years ago

I'm interested on this, any updates?

schlbra commented 2 years ago

Is this feature just awaiting a review? This would be a great addition as we can't use this module as is.

bryantbiggs commented 2 years ago

Is this feature just awaiting a review? This would be a great addition as we can't use this module as is.

its waiting on me to finish it up, running a bit behind - my apologies. once I get https://github.com/terraform-aws-modules/terraform-aws-redshift/pull/61 across the line I'll focus on finish this one up as well

krishna-koushik commented 1 year ago

any update on this?

antonbabenko commented 1 year ago

@bryantbiggs Do you want me to work on this one? I am interested in improving https://serverless.tf , so this is a good addition.

bryantbiggs commented 1 year ago

@antonbabenko yes, please feel free to take this one over if you have the time

antonbabenko commented 1 year ago

Ok, I will work on it on Monday-Wednesday then.

ghost commented 10 months ago

Hi, are there any updates regarding this one? I'm really interested in this

choudharyac09 commented 1 month ago

Can We merge this pull request?

bryantbiggs commented 1 month ago

Can We merge this pull request?

Its being worked on, its currently in draft mode

choudharyac09 commented 1 month ago

@antonbabenko Can you please review the pull request?

antonbabenko commented 1 month ago

@antonbabenko Can you please review the pull request?

Yes, as soon as I can. Probably, tomorrow.

antonbabenko commented 3 weeks ago

This PR is included in version 5.0.0 :tada: