feat: Add pass-through of ownership_verification_certificate_arn to domain_name

kmannuz commented 2 years ago

Description

Adds the ability to also pass ownership_verification_certificate_arn to domain_name resource as new variable called domain_name_ownership_verification_certificate_arn. I followed existing patterns for defaults and naming conventions.

Motivation and Context

Users may need to configure ownership_verification_certificate_arn as part of aws_apigatewayv2_domain_name. See provider docs for use cases

Breaking Changes

N/A - defaults to null, which is currently implied

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[X] I have tested and validated these changes using one or more of the provided examples/* projects
[X] I have executed pre-commit run -a on my pull request

kmannuz commented 2 years ago

LGTM, please update the minimum version of AWS provider in versions.tf to be >= 4.0 since this feature was added in 4.0.0.

Done!

antonbabenko commented 2 years ago

This PR is included in version 1.9.0 :tada:

antonbabenko commented 2 years ago

I have made a mistake (#73) by not bumping a major version when merging this PR.

v1.9.0 should not have been created. Please use v2.0.0 which was created in #74.

Sorry for the confusion!

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-apigateway-v2