Closed honglus closed 1 year ago
pull request #80
This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Is your request related to a problem? Please describe.
route_settings are in main.tf but are commented out, Maybe it was due to a bug in AWS provider, But anyway I tested it worked with throttling_burst_limit and throttling_rate_limit with AWS v4.25.0 https://github.com/terraform-aws-modules/terraform-aws-apigateway-v2/blob/master/main.tf#L92 Simply uncomment the block won't work with reason below.
Describe the solution you'd like.
route_settings will override default_settings, So even I just want to set throttling_rate_limit on route
"POST /test",
I have to set the remaining variables to use default_route_settings values, otherwise it will be AWS default value not default_route_settings value. e.gdetailed_metrics_enabled
will becomefalse
. Enable route_settings and add only the route with at least one of the options:data_trace_enabled, logging_level, throttling_burst_limit, throttling_rate_limit, detailed_metrics_enabled
is not null set the remaining variables to use use default_route_settings values