terraform-aws-modules / terraform-aws-apigateway-v2

Terraform module to create AWS API Gateway v2 (HTTP/WebSocket) 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/apigateway-v2/aws
Apache License 2.0
148 stars 200 forks source link

feat: Enable route_settings in default stage #80

Closed honglus closed 2 years ago

honglus commented 2 years ago

Description

Enable route_settings in default stage route_settings will override default_settings, So even I just want to set throttling_rate_limit on route "POST /test", I have to set the remaining variables to use default_route_settings values, otherwise it will be AWS default value not default_route_settings value. e.g detailed_metrics_enabled will become false.

Motivation and Context

78

Breaking Changes

No

How Has This Been Tested?

I have tested and deployed to my company AWS environment.

honglus commented 2 years ago

sorry, it is not easy for me to provision all resources in the example. Can you try 1) examples/complete-http is successful before the change. 2) try to pin AWS version to v4.25.0, which is the version I tested successfully for my company's resource.

antonbabenko commented 2 years ago

I am pretty sure that example worked before this PR. I will take a look into this PR during this week.

antonbabenko commented 2 years ago

This PR is included in version 2.2.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.