feat!: Added the fail_on_warnings variable, bumped Terraform version to 1.0+

terraform-aws-modules / terraform-aws-apigateway-v2

Terraform module to create AWS API Gateway v2 (HTTP/WebSocket) 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/apigateway-v2/aws

Apache License 2.0

144 stars 187 forks source link

feat!: Added the fail_on_warnings variable, bumped Terraform version to 1.0+ #96

Closed thenom closed 4 months ago

thenom commented 5 months ago

Description

Enable the fail_on_warnings variable Also removed skip_get_ec2_platforms from the provider as this has now been remove from v5

Motivation and Context

Allow users to use the variable in the underlying resource

Breaking Changes

none, defaults to exisiting functionality

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

thenom commented 4 months ago

Looks good. Could you also fix the failing CI checks?

Done, think that last commit should cover it

antonbabenko commented 4 months ago

Please update some versions to make CI green.

antonbabenko commented 4 months ago

This PR is included in version 3.0.0 :tada:

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.