terraform-aws-modules / terraform-aws-atlantis

Terraform module to deploy Atlantis on AWS Fargate 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/atlantis/aws
Apache License 2.0
520 stars 351 forks source link

Error with EFS security group #320

Closed chroju closed 2 years ago

chroju commented 2 years ago

Description

Please provide a clear and concise description of the issue you are encountering, and a reproduction of your configuration (see the examples/* directory for references that you can copy+paste and tailor to match your configs if you are unable to copy your exact configuration). The reproduction MUST be executable by running terraform init && terraform apply without any further changes.

If your request is for a new feature, please use the Feature request template.

⚠️ Note

Before you submit an issue, please perform the following first:

  1. Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
  2. Re-initialize the project root to pull down modules: terraform init
  3. Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Reproduction Code [Required]

Steps to reproduce the behavior:

This is example, not actually code. The key point is that EFS is used instead of Fargate ephemeral storage.

module "atlantis" {
  source  = "terraform-aws-modules/atlantis/aws"
  version = "3.23.1"

  name = "atlantis"

  # VPC
  vpc_id             = module.atlantis_vpc.vpc_id
  private_subnet_ids = module.atlantis_vpc.private_subnets
  public_subnet_ids  = module.atlantis_vpc.public_subnets

  # ECS
  ecs_fargate_spot = false
  ecs_task_cpu     = 1024
  ecs_task_memory  = 2048

  # Atlantis
  atlantis_version               = "v0.20.0"
  atlantis_fqdn                  = local.atlantis_fqdn
  atlantis_github_webhook_secret = local.atlantis_github_webhook_secret
  allow_github_webhooks          = true
  allow_repo_config = true
}

Expected behavior

Works fine.

Actual behavior

This error.

image

Terminal Output Screenshot(s)

Additional context

This is probably the same issue reported for the terraform-aws-security-group module.

chroju commented 2 years ago

Unfortunately, this works with aws provider v4, but seems to cause an error with v3. It was my environmental issue.

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.