terraform-aws-modules / terraform-aws-atlantis

Terraform module to deploy Atlantis on AWS Fargate 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/atlantis/aws
Apache License 2.0
520 stars 351 forks source link

Lifecycle ignore change for "value" in SSM Parameter Store #327

Closed circleous closed 1 year ago

circleous commented 1 year ago

Is your request related to a problem? Please describe.

Secret token resources often get regenerated on a timely basis for security best practices but without ignore_changes to value, this will override the current value stored in the parameter store

Describe the solution you'd like.

Maybe add lifecycle ignore_changes to the value?

  lifecycle {
    ignore_changes = [
      value,
    ]
  }

Describe alternatives you've considered.

or add an option to not create the SSM parameter resource so that it can be managed outside this module.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 1 year ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.