terraform-aws-modules / terraform-aws-atlantis

Terraform module to deploy Atlantis on AWS Fargate 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/atlantis/aws
Apache License 2.0
520 stars 351 forks source link

feat: Add profile and region variables #328

Closed Ileriayo closed 1 year ago

Ileriayo commented 1 year ago

Description

This change adds profile and region variables so that the user can specify which AWS account on their machine they would like to use. It also updates the terraform.tfvars.sample to include variables for using GitHub apps instead of Personal Access Tokens.

Motivation and Context

A user may have more than one AWS account and would like to use either. This change allows them to specify which AWS profile to use, other than the default profile. It also allows you to specify a region rather than hard-coding it. If no region is specified, the original hard-coded region has been made the default.

Breaking Changes

No breaking changes

How Has This Been Tested?

bryantbiggs commented 1 year ago

thank you for the PR but this is not a valid change - this is an example and users are responsible for configuring the provider to suite their requirements

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.