terraform-aws-modules / terraform-aws-atlantis

Terraform module to deploy Atlantis on AWS Fargate πŸ‡ΊπŸ‡¦
https://registry.terraform.io/modules/terraform-aws-modules/atlantis/aws
Apache License 2.0
520 stars 351 forks source link

fix(environment_variable): Configure TF_PLUGIN_CACHE_MAY_BREAK_DEPENDENCY_LOCK_FILE #353

Closed jseiser closed 1 year ago

jseiser commented 1 year ago

Description

Allows setting TF_PLUGIN_CACHE_MAY_BREAK_DEPENDENCY_LOCK_FILE

Motivation and Context

So cache behavior works in 1.4+ Closes #352

Breaking Changes

N/A

How Has This Been Tested?

jseiser commented 1 year ago
Terraform validate.......................................................Failed
- hook id: terraform_validate
- exit code: 1

This hook fails, to a things I did not change. I assume its because this module is so behind provider wise.

Validation failed: .
β•·
β”‚ Warning: Argument is deprecated
β”‚ 
β”‚   with module.vpc.aws_eip.nat,
β”‚   on .terraform/modules/vpc/main.tf line 1068, in resource "aws_eip" "nat":
β”‚ 1068:   vpc = true
β”‚ 
β”‚ use domain attribute instead
β•΅
β•·
β”‚ Error: Unsupported argument
β”‚ 
β”‚   on main.tf line 597, in data "aws_iam_policy_document" "ecs_task_access_secrets_with_kms":
β”‚  597:   source_json = data.aws_iam_policy_document.ecs_task_access_secrets.json
β”‚ 
β”‚ An argument named "source_json" is not expected here.
β•΅
jseiser commented 1 year ago

@bryantbiggs

Any ideas on these failing git hooks?

jseiser commented 1 year ago

custom_environment_variables

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.