search

terraform-aws-modules / terraform-aws-atlantis

Terraform module to deploy Atlantis on AWS Fargate 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/atlantis/aws
Apache License 2.0
520 stars 351 forks source link

Can we make the ALB Subnet Type agnostic? #365

Closed ChrisJBurns closed 1 year ago

ChrisJBurns commented 1 year ago

Is your request related to a problem? Please describe.

We currently deploy our ALB in private subnets within AWS. But the var that is used in the alb module makes reference to local.public_subnet_ids.

For now, we have passed in our private subnet id under the var.public_subnet_ids with a big comment detailing why - but as you can imagine, it's not ideal.

Describe the solution you'd like.

I'd like the subnet variable names to be agnostic as it makes assumptions on the type of subnets people use for their ALB's, as many deploy ALB's into private subnets, it's not just public ones.

bryantbiggs commented 1 year ago

resolved in #366

github-actions[bot] commented 11 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.