feat: Add support for different name for EFS

terraform-aws-modules / terraform-aws-atlantis

Terraform module to deploy Atlantis on AWS Fargate 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/atlantis/aws

Apache License 2.0

520 stars 351 forks source link

feat: Add support for different name for EFS #392

Closed Andrews-repo closed 8 months ago

Andrews-repo commented 8 months ago

Description

The logic to name EFS was added, but it is tied to the main "name" variable for the module, and does not contain the logic to allow for uniques names when passing them in differently.

Motivation and Context

Declaring a unique name in the EFS array did not allow for setting unique names. Default/unique name for the module was applied from the Atlantis module.

antonbabenko commented 8 months ago

This PR is included in version 4.2.0 :tada:

github-actions[bot] commented 7 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.