terraform-aws-modules / terraform-aws-atlantis

Terraform module to deploy Atlantis on AWS Fargate 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/atlantis/aws
Apache License 2.0
520 stars 351 forks source link

chore: Working examples for repo_allowlist (#394) #395

Closed fmudhir closed 7 months ago

fmudhir commented 7 months ago

Description

This adds a new input var for the github host, then combines that domain + owner + repo list to produce full url.

More details: https://github.com/terraform-aws-modules/terraform-aws-atlantis/issues/394, https://github.com/terraform-aws-modules/terraform-aws-atlantis/issues/384

Motivation and Context

Following the README will default to non-working atlantis_repo_allowlist for webhooks, or for atlantis module (depends on whether you try terraform-aws-modules/terraform-aws-atlantis or terraform-aws-atlantis. (User will get Error: This repo is not allowlisted for Atlantis.)

Breaking Changes

No. Just documentation example update, but important for someone following these examples.

How Has This Been Tested?

github-actions[bot] commented 6 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

antonbabenko commented 6 months ago

This issue has been resolved in version 4.2.1 :tada: