search

terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws
Apache License 2.0
293 stars 556 forks source link

new KMS feature is a breaking change #116

Closed mrtristan closed 4 years ago

mrtristan commented 4 years ago

lesson learned as far as locking my version down. choking on the version that came out literally moments ago... :-)

getting the following error:

Error: Unsupported argument

  on .terraform\modules\XXXXXXX.asg\terraform-aws-autoscaling-3.7.0\main.tf line 27, in resource "aws_launch_configuration" "this":
  27:       kms_key_id            = lookup(ebs_block_device.value, "kms_key_id", null)

An argument named "kms_key_id" is not expected here.

is it intended to be a breaking change?

antonbabenko commented 4 years ago

Which AWS provider version do you use?

PS: Yes, please always pin the provider's version.

antonbabenko commented 4 years ago

You are right, this is a bad release. I will fix it now :(

mrtristan commented 4 years ago

yeah i've got most module references pinned but found that my asg module ref (a few modules down) only had a lower bound on the version pinning which allowed it to sneak this in. thanks for the quick action

antonbabenko commented 4 years ago

Thanks for reporting! 👍

antonbabenko commented 4 years ago

Now there is no such tag even, so you should be able to just remove cache from .terraform directory and run terraform init.

mrtristan commented 4 years ago

yep. saw you pulled it. was going to do that but figured i should do the "right" thing and pin it properly and propagate that up. thanks again.

github-actions[bot] commented 2 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.