feat: update module to include launch template support, mixed instances policy, instance refresh, etc.

bryantbiggs commented 3 years ago

Description

add support for utilizing launch templates
add support for mixed instances policy
add support for instance refresh
refactor to utilize only a single autoscaling group resource using dynamic blocks (previously separate for lifecycle hooks)
refactor examples to cover nearly all use cases and configurations
update examples and documentation to reflect changes

Motivation and Context

bring module up to date based on what is available and requested by the broader community

closes #51 closes #54 closes #76 closes #84 closes #86 closes #117 closes #124 closes #126 closes #130 closes #137

Breaking Changes

Yes! This is quite a massive change from the current module version and should be released as the next major version (i.e. - v4.0.0)

For users that come across this change/release - the recommended approach to updates would be to provision a new autoscaling group alongside your existing before deprecating/removing the existing autoscaling group. if you are using load balancers in front of your autoscaling groups, this is a matter of updating the target groups. autoscaling groups are generally meant to be orchestrating instances that are ephemeral (or that can be replaced) and therefore provisioning a new autoscaling group alongside your existing and switching any load/traffic over to it should suffice for those who wish to upgrade.

How Has This Been Tested?

[x] I have tested and validated these changes using one or more of the provided examples/* projects
I have both updated and validated all examples - examples cover nearly all configurations and settings

bryantbiggs commented 3 years ago

@antonbabenko / @terraform-aws-modules/triage-supporters if you all get some time or have some feedback

bryantbiggs commented 3 years ago

ok should be all set @antonbabenko

antonbabenko commented 3 years ago

As the last thing for this massive upgrade, can you write an upgrade guide (similar to this one from ALB module)? Maybe include some rough terraform state mv commands and a list of renamed variables and outputs. I am pretty sure users will appreciate such information in one place.

bryantbiggs commented 3 years ago

@antonbabenko added something in https://github.com/terraform-aws-modules/terraform-aws-autoscaling/pull/139/commits/301ef7c6ef1d2588671c0082facc4f76c3dac43a - let me know what you think

bryantbiggs commented 3 years ago

@antonbabenko I think we should be all set. I'll watch for any issues that pop up and address as quickly as I can. we can always update the upgrade doc as well if any feedback comes in 👍🏼

bansawbanchee commented 3 years ago

I'm currently using a forked version of this update in production and it works perfectly. I'd like to migrate to an official release. What is the timeframe on getting this merged in?

Appreciate all the hard work you guys put into this, for real.

antonbabenko commented 3 years ago

@bansawbanchee It will be released during an hour (running it for the last time as we speak).

antonbabenko commented 3 years ago

We wanted to drop Terraform 0.12 during this major release but this code actually works with 0.12 :) Great job @bryantbiggs !

v4.0.0 has been just released.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-autoscaling