search

terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws
Apache License 2.0
292 stars 556 forks source link

feat: Add support for `warm_pool` #142

Closed curiositycasualty closed 3 years ago

curiositycasualty commented 3 years ago

Description

Adds support for aws_autoscaling_group's warm_pool configuration.

Motivation and Context

This isn't a hill I need to die on. If this change is risky for some reason that's non-obvious to me, we can forego a merge of this.

Breaking Changes

This is a relatively new feature to the underlying aws provider: https://github.com/hashicorp/terraform-provider-aws/pull/18734

How Has This Been Tested?

See supplied example.

bryantbiggs commented 3 years ago

hey thanks for the PR @curiositycasualty ! I think this looks great, I'll find some time to test and validate. one thing we'll need to update is the min AWS provider version to 3.37.0 per https://github.com/hashicorp/terraform-provider-aws/pull/18734#issuecomment-821296130

sudermanjr commented 3 years ago

I just found this feature, and it might be just what I need. Any chance of this getting updated per review and added in?

verejoel commented 3 years ago

+1 for seeing this revived, definitely would like to use this feature!

curiositycasualty commented 3 years ago

@bryantbiggs Have you had a change to poke this? I just rebased and got things "semantic".

denraf commented 3 years ago

@curiositycasualty What @bryantbiggs was saying is to update the aws minimum version requirement in versions.tf

      version = ">= 3.37"
curiositycasualty commented 3 years ago

Thanks @denraf. Sorry for the delay.

curiositycasualty commented 3 years ago

@bryantbiggs This is ready for review.

curiositycasualty commented 3 years ago

tumbleweed rolles by

bryantbiggs commented 3 years ago

apologies, looks good if you can fix the conflicts and rebase master - 👍🏽 @antonbabenko

image
antonbabenko commented 3 years ago

Thanks @curiositycasualty for the PR!

v4.6.0 has been just released.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.