fix: Added variable to control propagation of the ASG Name tag to instances

leigholiver commented 3 years ago

Description

Adds a variable to control the propagate_at_launch field of the Name tag added by the module.

Motivation and Context

When providing tags for the ASG, a Name tag is added by the module, with propagate_at_launch set to true. This takes precedent over tag_specifications, meaning any instance launched by the ASG will have the same name as the ASG, and this cannot be overridden as described in https://github.com/terraform-aws-modules/terraform-aws-autoscaling/issues/144#issuecomment-828047102

Breaking Changes

None

How Has This Been Tested?

[X] I have tested and validated these changes using one or more of the provided examples/* projects
The complete example project was applied and destroyed using Terraform 0.14.11

antonbabenko commented 3 years ago

v4.4.0 has been just released.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-autoscaling