terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws
Apache License 2.0
292 stars 557 forks source link

spot instances no longer support block duration #156

Closed jpriebe closed 2 years ago

jpriebe commented 3 years ago

Description

The examples in the documenation have this option:

spot_options = {
  block_duration_minutes = 60
}

AWS fails to launch instances in the ASG, with this error message:

BlockDurationMinutes is not a valid parameter. Launching EC2 instance failed.

As of July 2021, block duration is no longer supported for users who have not used the feature before, and support will be dropped for all users at the end of 2022. See update on this page:

https://aws.amazon.com/blogs/aws/new-ec2-spot-blocks-for-defined-duration-workloads/

Update July 2021 – Spot Instances with a defined duration (also known as Spot blocks) are no longer available to new customers as of July 1, 2021. For customers that have previously used the feature, we will continue to support Spot Instances with a defined duration until December 31, 2022. If your workload is interruption tolerant, we recommend that you use Spot Instances without setting a defined duration. If your workload is not interruption tolerant we recommend that you use On-Demand instances for the required duration of your workload.

antonbabenko commented 2 years ago

This issue has been resolved in version 4.9.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.