terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws
Apache License 2.0
292 stars 556 forks source link

Support Create Before Destroy #157

Closed bhardister closed 3 years ago

bhardister commented 3 years ago

I found that if the min size is 2 and the desired capacity is 2, the instance refresh will terminate 1 instance first before launching the new one. When coded as follows:

instance_refresh = { strategy = "Rolling" preferences = { min_healthy_percentage = 100 } }

Shouldn't it launch a new active and terminate an instance only after the new one is in the LB TG and healthy?

antonbabenko commented 3 years ago

I think you should ask this question in some AWS-specific forum (like StackOverflow). This is not related to the module.

https://docs.aws.amazon.com/autoscaling/ec2/userguide/asg-instance-refresh.html - here is official documentation by AWS.

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.