terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws
Apache License 2.0
292 stars 556 forks source link

Since 4.0.0 the ASG name is used to fill the EC2 "Name" tag #158

Closed gmconte closed 2 years ago

gmconte commented 3 years ago

Description

since version 4.0.0 the variable asg_name has been removed. This was very useful to separate the name of the ASG from the variable name, which is included as tag "Name" and propagated to the EC2 instances. Now, the only variable we can use is name which means that I need to either change the name of my ASG (and the Cloudwatch metrics, alarms, etc associated) or let the new version change the Name tag of my EC2 instances (and so all the EC2 Cloudwatch metrics, alarms, etc).

I can't set the "Name" tag anywhere because it gets randomly overwritten by the hardcoded "Name" tag when the code builds the local.tags variable in main.tf, so there's no workaround unless I modify my user_data to change the tag from the instance itself.

Versions

Reproduction

Steps to reproduce the behavior: Configure ASG in version 3.9.0 set the variables:

now upgrade to version 4.x.x

Expected behavior

naming of ASG should be separate from the name tag propagated to the EC2 instances. In 3.9.0 this meant accepting that the ASG had the same Name tag as the EC2, which is ok.

Actual behavior

The asg_name variable is not valid anymore I have to either change the Name tag of the EC2 instance or the ASG name

Possible solutions:

antonbabenko commented 2 years ago

This issue has been resolved in version 4.9.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.