search

terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws
Apache License 2.0
292 stars 556 forks source link

Support default_tags propagation #162

Closed dekimsey closed 2 years ago

dekimsey commented 2 years ago

Is your request related to a new offering from AWS?

No

Is your request related to a problem? Please describe.

The AWS provider's default_tags are not propagated to the instances created by the ASG. If I attempt to do this manually it causes apply churn in the related aws_launch_template resource.

There's a learn article on how to do this, but it involves doing a data lookup on aws_default_tags.

Describe the solution you'd like.

I would like provider default_tags to be properly propagated and not cause apply churn.

Describe alternatives you've considered.

I am currently passing the tags myself via a merge() in tags_as_map = merge(...) however this is causing apply churn on the aws_launch_template resource as it also has the provider default tags applied.

Additional context

The default_tags parameter was added in 3.38.0.

antonbabenko commented 2 years ago

This issue has been resolved in version 4.9.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.