feat: add checkpoint_delay, checkpoint_percent to instance refresh

terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws

Apache License 2.0

292 stars 556 forks source link

feat: add checkpoint_delay, checkpoint_percent to instance refresh #166

Closed alarmstrong closed 2 years ago

alarmstrong commented 2 years ago

Description

checkpoint_delay - (Optional) The number of seconds to wait after a checkpoint. Defaults to 3600. checkpoint_percentages - (Optional) List of percentages for each checkpoint. Values must be unique and in ascending order. To replace all instances, the final number must be 100.

Parameter docs: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group#preferences

How Has This Been Tested?

I have tested and validated these changes using one or more of the provided examples/* projects, triggered instance refresh by editing a tag and redeploying

alarmstrong commented 2 years ago

any further input from me on this?

antonbabenko commented 2 years ago

@bryantbiggs Do you have any idea why pre-commit checks succeeded for this commit - db520a9 ( https://github.com/terraform-aws-modules/terraform-aws-autoscaling/runs/4210380482?check_suite_focus=true ) though the AWS provider version was not updated in README? When I run pre-commit run -a locally it correctly updated the files.

@aarmstrong-gel Looks good, I will merge it now. Thank you!

antonbabenko commented 2 years ago

Here we go!

v4.8.0 has been just released.

bryantbiggs commented 2 years ago

@antonbabenko it looks like a bug in the existing/old CI check workflow. I ran some tests to confirm

see individual commits on this https://github.com/terraform-aws-modules/terraform-aws-autoscaling/pull/167
confirmed it works as intended on new workflow https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/pull/258

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.