fix: update CI/CD process to enable auto-release workflow

terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws

Apache License 2.0

292 stars 556 forks source link

fix: update CI/CD process to enable auto-release workflow #168

Closed bryantbiggs closed 2 years ago

bryantbiggs commented 2 years ago

Description

add new hook to pre-commit to fix eof lines
add new release.yml workflow. this workflow will automatically:
- create and push new tag for next semver based on conventional-commits
- create GitHub release with notes
- update Changelog with release notes
- this workflow will also automatically notify PRs that are included in the release, mimicking the manual behavior but now its automated https://github.com/clowdhaus/terraform-aws-rds/pull/1#issuecomment-952097291
remove old chglog configs and Makefile

Motivation and Context

automate release process in a standardized manner
standardize new CI workflow (copying from RDS Aurora)

Breaking Changes

How Has This Been Tested?

[x] https://github.com/terraform-aws-modules/terraform-aws-rds/pull/361

antonbabenko commented 2 years ago

LGTM. In the near future, I want to bring the management of these meta/CI/release-related files under management by https://github.com/terraform-aws-modules/meta/ repository where they were some time ago. I think I found a way for doing this in an easy way using a native GitHub provider.

Let's merge this kind of PRs only in some repositories just to reduce the amount of extra work I should go through when running "import" in meta-repository (if there will be any extra work, I need to verify the flow still). I plan to do spend some time on this on Friday.

antonbabenko commented 2 years ago

Wanted to release manually but failed - https://github.com/terraform-aws-modules/terraform-aws-autoscaling/actions/runs/1462253602 :(

bryantbiggs commented 2 years ago

it looks like it still released and updated the changelog correctly

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.