terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws
Apache License 2.0
292 stars 556 forks source link

feat: add missing attributes to launch template, remove null resource for tag propagation, propagate default tags to instances, allow propagated name to be set independently of ASG #169

Closed bryantbiggs closed 2 years ago

bryantbiggs commented 2 years ago

Description

Motivation and Context

Breaking Changes

No, but users will see some updates in their plans with the switch from null resource to list comprehension of propagated tags

# module.complete_lc.null_resource.tags_as_list_of_maps[0] will be destroyed
  - resource "null_resource" "tags_as_list_of_maps" {
      - id       = "4889299483352056787" -> null
      - triggers = {
          - "key"                 = "Environment"
          - "propagate_at_launch" = "true"
          - "value"               = "dev"
        } -> null
    }

How Has This Been Tested?

bryantbiggs commented 2 years ago

@antonbabenko this one should be ready if you have some time

antonbabenko commented 2 years ago

This PR is included in version 4.9.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.