feat!: Update autoscaling group `tags` -> `tag` to support v4 of AWS provider

bryantbiggs commented 2 years ago

Description

Update autoscaling group tags -> tag to support v4 of AWS provider which is now a tag block as opposed to a standard attribute
var.propagate_name has been removed
var.tags_as_map has been moved into var.tags and now var.tags just takes the standard map(string) map of key value pairs for tags. The tags provided are propagated to instances launched through the dynamic tag block
fix example for predictive scaling policy which caught some issues in the nested map lookup logic that has been corrected
var.tags are now automatically merged with var.tag_specifications

Motivation and Context

Avoids showing users a deprecation statement for tags on autoscaling group
Simplify tag usage and removes constant tag updates in each plan/apply

Breaking Changes

Yes
- var.propagate_name has been removed
- var.tags_as_map has been moved into var.tags and now var.tags just takes the standard map(string) map of key value pairs for tags. The tags provided are propagated to instances launched through the dynamic tag block
Users will need to ensure that the value they are passing to var.tags is the standard map of key=value pairs (map(string))

How Has This Been Tested?

[x] I have tested and validated these changes using one or more of the provided examples/* projects

bryantbiggs commented 2 years ago

ok should be ready for review now if you get some time @antonbabenko

antonbabenko commented 2 years ago

@bryantbiggs I am pretty much off with corona since Wednesday. Only obvious PRs can be processed by me before Monday 🤯

bryantbiggs commented 2 years ago

@antonbabenko no rush at all - sorry to hear, hope you feel better soon!

antonbabenko commented 2 years ago

This PR is included in version 5.0.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-autoscaling