terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws
Apache License 2.0
289 stars 553 forks source link

Unable to not propagate a tag (update from 4.11.0 to 5.0.0) #198

Closed giom-l closed 1 year ago

giom-l commented 2 years ago

Description

I'm currently updating some stacks that use autoscaling modules from v4.11.0 to 5.0.0 (I'll have to deal with launch config -> launch templates to go any further).

Between those 2 releases, the main change is about tags. Before, I could add tags to the ASG that would not be propagated to instances by setting

tags_as_map = merge(
    local.tags,
    var.instances_tags,
    {
      "Name"  = local.name
    }
  )

  // We use the tags (instead of tags_as_map) for this specific tag, so it is not propagated to the instance.
  tags = [
    {
      key                 = "Whatever"
      value               = "whocares"
      propagate_at_launch = false
    }
  ]

This let us interoperate with external components that act on ASG (but could mess up with instances sometimes if they have tags set).

With autoscaling module >4.11, I can't figure out how I could handle the same since all tags have set

propagate = true

Is it expected to have removed the ability to not propagate tags (Or am I missing something ? )

Versions

giom-l commented 2 years ago

Since I updated to the latest release to date (6.5.1), I tried to reproduce the behaviour of not propagating the tag. Still not possible even with tag_specification as all tags are merged with tag_specification

smartjy commented 2 years ago

Hi i tried tagging block_device_mappings but no tags are created EBS Volume device, is there any way to tagging?

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 1 year ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.