Added support for passing null in instance_market_options

terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws

Apache License 2.0

292 stars 556 forks source link

Added support for passing null in instance_market_options #211

Closed rysi3k closed 1 year ago

rysi3k commented 1 year ago

Description

Added support for conditional passing instance_market_options.

Motivation and Context

Fixes https://github.com/terraform-aws-modules/terraform-aws-autoscaling/issues/208

Breaking Changes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[ ] I have executed pre-commit run -a on my pull request

bryantbiggs commented 1 year ago

thank you but this is not a change that we will be accepting. I will again suggest revisiting the way in in which you are using terraform

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.