terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws
Apache License 2.0
292 stars 556 forks source link

feat: Add support for `default_instance_warmup` argument #213

Closed zwick closed 1 year ago

zwick commented 1 year ago

Description

This change adds support for an optional input variable (default_instance_warmup) for the autoscaling_group resource being created. See autoscaling_group.

Motivation and Context

We had a need to modify the default warmup time behavior of ec2 instances in an Autoscaling Group. We are using this module and could only accomplish this by running a CLI command on the existing ASG, but the underlying resource supports assigning it in the Terraform resource.

Resolves #212

Breaking Changes

This change is additive and optional. There should be no breaking change.

I was not able to deploy the example for testing due to our organizations AWS permission restrictions, but I have updated the example to include the usage

How Has This Been Tested?

antonbabenko commented 1 year ago

This PR is included in version 6.7.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.