feat: Add support for `disable_api_stop`

terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws

Apache License 2.0

292 stars 556 forks source link

feat: Add support for `disable_api_stop` #218

Closed schniber closed 1 year ago

schniber commented 1 year ago

Description

This PR implements the feature request #217

Motivation and Context

This PR allows to disable_api_stop at the launch template level.

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[X] I have executed pre-commit run -a on my pull request

bryantbiggs commented 1 year ago

we'll need to update all of the versions to at least v4.20.0 of the provider https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#4200-june-23-2022

schniber commented 1 year ago

@bryantbiggs : Thanks for your review. well spotted ! Bests !

antonbabenko commented 1 year ago

This PR is included in version 6.6.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.