feat: Support `desired_capacity_type` and add mixed instance launch template override `instance_requirements` for ASG

terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws

Apache License 2.0

289 stars 553 forks source link

feat: Support `desired_capacity_type` and add mixed instance launch template override `instance_requirements` for ASG #220

Closed magreenbaum closed 1 year ago

magreenbaum commented 1 year ago

Description

Add desired_capacity_type and mixed instance launch template override instance_requirements for ASGs.

Motivation and Context

https://github.com/hashicorp/terraform-provider-aws/pull/24795 https://github.com/hashicorp/terraform-provider-aws/issues/21566

Breaking Changes

No.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

magreenbaum commented 1 year ago

Unstale

bryantbiggs commented 1 year ago

whoops - sorry, I forgot about this one. I've marked it to take a look tomorrow

antonbabenko commented 1 year ago

This PR is included in version 6.8.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.