search

terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws
Apache License 2.0
287 stars 552 forks source link

Add auto_rollback feature to this module in instance_refresh settings #231

Closed satish4584 closed 1 year ago

satish4584 commented 1 year ago

Is your request related to a new offering from AWS?

Is your request related to a problem? Please describe.

Spacelift uses this module and we are enabling instance refresh on our private worker but auto_rollback is missing in this module so with this pr is all about adding auto_rollback feature to this module. Here is the spacelift PR related pull request. https://github.com/spacelift-io/terraform-aws-spacelift-workerpool-on-ec2/pull/46

Describe the solution you'd like.

antonbabenko commented 1 year ago

This issue has been resolved in version 6.10.0 :tada:

glg-satish-tripathi commented 1 year ago

Glad to hear that. Thank you @antonbabenko

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.