fix: Removed deprecated option and updated readme - asg deploys

terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws

Apache License 2.0

292 stars 558 forks source link

fix: Removed deprecated option and updated readme - asg deploys #239

Closed glangston83 closed 1 year ago

glangston83 commented 1 year ago

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_RequestSpotInstances.html

Description

block_duration_minutes spot instances option is deprecated

Motivation and Context

Removing a deprecated option from request_spot_instances API

Breaking Changes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

glangston83 commented 1 year ago

tested with main code example resulted in terraform apply working setting up ASG, but instances would launch with same error as https://github.com/aleks-fofanov/terraform-gitlab-runner-aws-spot/issues/3

Removed deprecated code and re-tested and spot instances launched

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 1 year ago

This PR was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.