fix: Added all instance refresh options, including scale in protection and standby instances

[mickmorse]

Description

Not all preferences were available in the instance_refresh map. I've added the rest of them in.

Motivation and Context

I was getting the below error when using the module:

ValidationError: 2 validation errors detected: Value '' at 'preferences.scaleInProtectedInstances' failed to satisfy constraint: Member must satisfy enum value set: [Ignore, Wait, Refresh]; Value '' at 'preferences.standbyInstances' failed to satisfy constraint: Member must satisfy enum value set: [Terminate, Ignore, Wait]

Breaking Changes

Since all parameters are optional. There are no breaking changes

How Has This Been Tested?

• [x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
• [x] I have tested and validated these changes using one or more of the provided examples/* projects
• [x] I have executed pre-commit run -a on my pull request

[jseiser]

We are also hitting this error now.

I assume the issue is coming in from the new AWS provider: https://github.com/hashicorp/terraform-provider-aws/issues/33310

[adiospeds]

Thanks for the PR - We hit the same issue:

Value '' at 'preferences.scaleInProtectedInstances' failed to satisfy constraint: Member must satisfy enum value set: [Ignore, Wait, Refresh]; 
Value '' at 'preferences.standbyInstances' failed to satisfy constraint: Member must satisfy enum value set: [Terminate, Ignore, Wait]

One thing I'd like to bring to notice is the documentation for scale_in_protected_instances and standby_instances says Default values as Wait, so those should also get Updated if this PR is approved, or set the value in this PR from Ignore to Wait

[bryantbiggs]

Please open an issue on the AWS provider - this sounds like a bug for the provider

[mhowell-ims]

I've opened https://github.com/hashicorp/terraform-provider-aws/issues/33377 .

You can avoid this bug by downgrading your AWS provider to 5.15.0.

[mhowell-ims]

There is already a PR for the bug in the AWS provider. Consider upvoting it. https://github.com/hashicorp/terraform-provider-aws/pull/33382

[mickmorse]

Thanks for the PR - We hit the same issue:

Value '' at 'preferences.scaleInProtectedInstances' failed to satisfy constraint: Member must satisfy enum value set: [Ignore, Wait, Refresh]; 
Value '' at 'preferences.standbyInstances' failed to satisfy constraint: Member must satisfy enum value set: [Terminate, Ignore, Wait]

One thing I'd like to bring to notice is the documentation for scale_in_protected_instances and standby_instances says Default values as Wait, so those should also get Updated if this PR is approved, or set the value in this PR from Ignore to Wait

This is done. Thanks for your input.

[bryantbiggs]

this should be resolved now with https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.16.2

[mickmorse]

this should be resolved now with https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.16.2

Well no because not all options are available in the instance refresh block. This PR was to make them available regardless of the bug.

[bryantbiggs]

that will require v5.x of the AWS provider and therefore a breaking change - this will be handled in #240

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.