Closed bryantbiggs closed 7 months ago
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
This PR is included in version 7.4.0 :tada:
Description
load_balancers
andtarget_group_arns
from useMotivation and Context
aws_autoscaling_traffic_source_attachment
in #248, this has introduced a second point of control for load balancer attachment which started showing up in diffs on the autoscaling group resource. In #252 we have suppressed this diff by ignoring all changes toload_balancers
andtarget_group_arns
used directly on the autoscaling group resource. In hindsight, this was not an ideal route for users. Going forward, at the next breaking change we should remove the use ofload_balancers
andtarget_group_arns
and strictly use thetraffic_source_*
arguments. Theaws_autoscaling_traffic_source_attachment
is more flexible and supports more resources than what the ASG resource does directly today. You can think of the similar lifecycle that security groups and security group rules have gone through (first rules were set on the group resource, later a separate resource was added for rules only, and then later a 3rd more explicit rule resource was added - all to differentiate between the different lifecycles of the resources and their behaviors)Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request