terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws
Apache License 2.0
288 stars 552 forks source link

feat: Adds `max_healthy_percentage` and `skip_matching` to autoscaling group #256

Closed easterbonbon closed 4 months ago

easterbonbon commented 4 months ago

Description

Adds max_healthy_percentage and skip_matching to aws_autoscaling_group instance_refresh.preferences.

Small aside: also updated the examples to look for an Amazon Linux 2 AMI rather than an Amazon Linux AMI which is EOL.

Motivation and Context

These two settings were added in the AWS Terraform provider and currently there is no way to specify them using this module.

max_healthy_percentage was added in v5.32.0 (see changelog) and skip_matching was added in v4.13.0 (see changelog)

Breaking Changes

No

How Has This Been Tested?

antonbabenko commented 4 months ago

This PR is included in version 7.4.0 :tada:

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.