Added option for default Name tagging

jurkjurk commented 3 months ago

Description

By default, the module applies a "Name" tag and sets propagate_at_start to true with no option, to disable such behaviour. I have added an option to override this hardcoded part.

Motivation and Context

I am using triggers and a lambda function to give newly created instances a Name tag, which is a combination of ASG name and instance ID. I cannot achieve this with having the tag hardcoded.

Breaking Changes

No changes as the newly introduced variable default to the current behaviour. Only if one sets it to false, new changes apply.

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[ x ] I have executed pre-commit run -a on my pull request

bryantbiggs commented 3 months ago

thank you, but this is not a change that we're going to accept

github-actions[bot] commented 2 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-autoscaling