terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws

Apache License 2.0

291 stars 557 forks source link

feat: add support for "kms_key_id" property in "ebs_block_device" and "root_block_device" #99

Closed sisivy closed 4 years ago

sisivy commented 4 years ago

Description

Add support for custom kms key for ebs and root block

Motivation and Context

Actually it is not possible to use custom kms key

sisivy commented 4 years ago

See: https://www.terraform.io/docs/providers/aws/r/instance.html#kms_key_id-1

bryantbiggs commented 4 years ago

thanks for the PR @sisivy - would you mind making a few changes please:

merge/rebase with master to update your branch to latest
change your pr title to something like feat: add support for "kms_key_id" property in "ebs_block_device" and "root_block_device"
update the asg_ec2 example to show/test usage

bryantbiggs commented 4 years ago

@antonbabenko :+1:

antonbabenko commented 4 years ago

Thanks, @sisivy and @bryantbiggs !

v3.7.0 has been just released.

antonbabenko commented 4 years ago

I deleted this release because this feature is not working as expected.

bryantbiggs commented 4 years ago

@antonbabenko could you share what the error or issue was?

antonbabenko commented 4 years ago

116

I checked CHANGELOG before the merge but didn't find anything there, but still merged. My bad, I should have verified it, too.

bryantbiggs commented 4 years ago

oh thats my bad - the link provided shows the instance resource, this attribute is not available on the launch configuration resource

antonbabenko commented 4 years ago

no problems 👍

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.