terraform-aws-modules / terraform-aws-batch

Terraform module to create AWS Batch resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/batch/aws
Apache License 2.0
35 stars 40 forks source link

fix: Change `instance_iam_role_use_name_prefix` to use correct data type #20

Closed jtzero closed 1 year ago

jtzero commented 1 year ago

Description

changes data type of variable "instance_iam_role_use_name_prefix" to bool

Motivation and Context

Is to align the correct data type, the result in putting in a string

Error: Incorrect condition type
│
│   on .terraform/modules/pull.batch/main.tf line 88, in resource "aws_iam_role" "instance":
│   88:   name        = var.instance_iam_role_use_name_prefix ? null : var.instance_iam_role_name
│     ├────────────────
│     │ var.instance_iam_role_use_name_prefix is "runner"
│
│ The condition expression must be of type bool.

Breaking Changes

No

How Has This Been Tested?

antonbabenko commented 1 year ago

This PR is included in version 2.0.1 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.